Conversation
Compose 플러그인에 추가
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a structured build logic and refactors dependency management for the project. Key changes include:
- Addition of utility functions for project property retrieval and Kotlin Android configuration.
- New extension functions for dependency handling.
- Implementation of various Gradle convention plugins for non-Android libraries, Android libraries (including Orbit, Naver Map, Hilt, Haze, Compose, Coil), and Android applications.
Reviewed Changes
Copilot reviewed 26 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build-logic/convention/src/main/kotlin/utils/ProjectExtensions.kt | Adds utility extensions for project properties and Kotlin Android configuration. |
| build-logic/convention/src/main/kotlin/utils/DependencyExtensions.kt | Introduces extension functions for common dependency configurations. |
| build-logic/convention/src/main/kotlin/NonAndroidLibraryConventionPlugin.kt | Configures conventions for non-Android Kotlin libraries. |
| build-logic/convention/src/main/kotlin/AndroidLibraryOrbitConventionPlugin.kt | Adds dependency configuration for Orbit libraries. |
| build-logic/convention/src/main/kotlin/AndroidLibraryNaverMapConventionPlugin.kt | Implements dependency inclusion for Naver Map libraries. |
| build-logic/convention/src/main/kotlin/AndroidLibraryHiltConventionPlugin.kt | Sets up Hilt dependency management and KSP integration. |
| build-logic/convention/src/main/kotlin/AndroidLibraryHazeConventionPlugin.kt | Configures dependency handling for Haze libraries. |
| build-logic/convention/src/main/kotlin/AndroidLibraryConventionPlugin.kt | Establishes Android library conventions with Kotlin Android configuration and dependency definitions. |
| build-logic/convention/src/main/kotlin/AndroidLibraryComposeConventionPlugin.kt | Adds Compose-specific plugin configuration and dependency handling. |
| build-logic/convention/src/main/kotlin/AndroidLibraryCoilConventionPlugin.kt | Integrates Coil library dependencies. |
| build-logic/convention/src/main/kotlin/AndroidApplicationConventionPlugin.kt | Sets up Android application configuration with signing settings and dependency management. |
| build-logic/convention/src/main/kotlin/AndroidApplicationComposeConventionPlugin.kt | Implements configuration for Android applications using Compose features. |
Files not reviewed (8)
- app/build.gradle.kts: Language not supported
- build-logic/convention/.gitignore: Language not supported
- build-logic/convention/build.gradle.kts: Language not supported
- build-logic/gradle.properties: Language not supported
- build-logic/settings.gradle.kts: Language not supported
- core/common/build.gradle.kts: Language not supported
- core/designsystem/build.gradle.kts: Language not supported
- core/map/build.gradle.kts: Language not supported
1971123-seongmin
approved these changes
Apr 22, 2025
Member
1971123-seongmin
left a comment
There was a problem hiding this comment.
고생하셨습니다 ~~
좀 이해가 안가긴 하는데 머지되면 전체 파일 보고 분석해볼게요
ThirFir
pushed a commit
that referenced
this pull request
May 1, 2025
[Feat/#62] onboarding 4번째 화면 UI 구현
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧨 Issue
💻 Work Description
💭 To Reviewers