Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved context unit testing #1749

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

BryceGattis
Copy link
Contributor

This PR adds some more unit testing coverage for resolved_context.py

TODO:

  • There's one ResolvedContext.Callback test that's failing because I can't seem to get the mocking to work as I expect.

Signed-off-by: BryceGattis <[email protected]>
Signed-off-by: BryceGattis <[email protected]>
@BryceGattis BryceGattis requested a review from a team as a code owner May 10, 2024 13:04
@JeanChristopheMorinPerso JeanChristopheMorinPerso force-pushed the resolved_context_unit_testing branch from 77d156d to eaed6ed Compare May 12, 2024 20:45
@JeanChristopheMorinPerso
Copy link
Member

Rebased in order to display the coverage information even if tests fail.

Signed-off-by: Jean-Christophe Morin <[email protected]>
Signed-off-by: Jean-Christophe Morin <[email protected]>
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (e215a77) to head (496a499).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1749      +/-   ##
==========================================
+ Coverage   58.39%   58.52%   +0.12%     
==========================================
  Files         126      126              
  Lines       17205    17209       +4     
  Branches     3519     3519              
==========================================
+ Hits        10047    10071      +24     
+ Misses       6491     6474      -17     
+ Partials      667      664       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeanChristopheMorinPerso
Copy link
Member

Sorry for the noise. I had to fix the coverage report... It should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants