fix: broken pgm having memory access error #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion#4561) Fixes AcademySoftwareFoundation#4553 Caught during fuzzing with address sanitizer. The file appeared to have a resolution so big it would not be able to satisfy the memory allocation. Solution: add the check_open to take an early abort if resolutions are bigger than could possibly be valid. Also have Strutil::stoi hande 32 bit overflow without UB overflow that the sanitizer complains about (that was the other cascading error that this same test case encountered in the sanitizer after the bad allocation). Signed-off-by: Larry Gritz <[email protected]>
jessey-git
approved these changes
Dec 9, 2024
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 23, 2024
…#4559) Fixes AcademySoftwareFoundation#4552 Caught during fuzzing with address sanitizer. The source of the problem was a corrupted/truncated pgm file. Several minor modifications in this PR shore up various cascading errors that followed. Not all were directly causal to the sanitizer trigger, in some cases I fixed what appeared to be related areas. * In imagebuf.cpp, any time we free the local pixel memory m_pixels, also explicitly clear the m_bufspan that has a span representation of the usable memory and its bounds. * An extra check related to oiiotool --printstats to make sure that the image is valid before passing along to stats collection. * In pnminput.cpp, a better error message when we hit a premature end of file. With these fixes in place, we seem to get a graceful error message and exit when running the POC that was provided with the bug report. Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4552
Caught during fuzzing with address sanitizer.
The source of the problem was a corrupted/truncated pgm file. Several minor modifications in this PR shore up various cascading errors that followed. Not all were directly causal to the sanitizer trigger, in some cases I fixed what appeared to be related areas.
With these fixes in place, we seem to get a graceful error message and exit when running the POC that was provided with the bug report.