[rqd] Add systemd-run launch mode #1758
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new `runSystemd` method to handle frame executions using `systemd-run` under Linux. This adds features like journaling and configurable properties for better resource management. Updated logic to utilize `runSystemd` instead of `runLinux`.
Add a comment to note the need for better handling of unset environment variables or failure to connect to the systemd-daemon.
Introduce a new `RQD_USE_SYSTEMD_RUN` configuration flag to toggle between `runSystemd` and `runLinux` methods for execution on Linux systems.
Add `cysystemd` version 2.0.1 to dependencies in `pyproject.toml`. Update `rqcore.py` to utilize `cysystemd.reader` for systemd journal reading, enhancing support for systemd functionality in RQD.
…d adjust systemd unit name format
Add a fallback mechanism to disable `RQD_USE_SYSTEMD_RUN` when `cysystemd` is not installed. Adjust imports dynamically to handle conditional usage of `cysystemd.reader`.
Add `import-outside-toplevel` to the pylint disable comments for `runSystemd` to address updated pylint rules.
Update `cysystemd` dependency to include a Python version constraint (`>=3.8`) in `pyproject.toml`.
…directory Add a temporary fix to delete `/usr/local/lib64/pkgconfig` to address an issue with the 2024 image in the testing pipeline.
…11 directory Extend the existing workaround for the 2024 image by adding steps to delete `/usr/local/lib64/python3.11`.
Simplify `cysystemd` dependency in `pyproject.toml` by removing the Python version constraint.
Move `cysystemd` to a dedicated `[systemd]` dependency group for better organization.
…nfig path substitution Extend the previous workaround by removing `pkgconfig/python*.pc` and updating `_sysconfigdata__linux_x86_64-linux-gnu.py` to address path issues in the 2024 image.
This was
linked to
issues
Jun 23, 2025
Improve the regular expression in the sed command to better handle path substitution for the Python environment fix.
…` in example config.
lithorus
requested review from
bcipriano,
DiegoTavares and
ramonfigueiredo
as code owners
DiegoTavares
requested changes
Jul 8, 2025
rqd/rqd/rqcore.py
Outdated
Comment on lines
975
to
977
| # TODO: Better handling if env vars are not set or not able to connect to the systemd-daemon | ||
| self.frameEnv['DBUS_SESSION_BUS_ADDRESS'] = os.environ['DBUS_SESSION_BUS_ADDRESS'] | ||
| systemdUnitName = f"rqd-{frameInfo.frameId}.service" |
There was a problem hiding this comment.
Please handle the case where the env is not set.
There was a problem hiding this comment.
Have added a check in rqconstants.py similar to checking for the python module and made the fetch safer, using .get()
rqd/rqd/rqcore.py
Outdated
| self.rqCore.updateRssThread.start() | ||
|
|
||
| returncode = frameInfo.forkedCommand.wait() | ||
| readerThread.join() |
There was a problem hiding this comment.
If an exception happens between the reader thread and here, you might have a thread leaked. Using a try/finally might add extra protection.
There was a problem hiding this comment.
Good point, will implement that.
There was a problem hiding this comment.
Has been added now
|
This looks like a good candidate to get your foot wet on rust/rqd. |
Have already been looking into a good library for interacting with journald, but still haven't found one I was satisfied with. |
DiegoTavares
approved these changes
Jul 28, 2025
|
Please document this feature before merging it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#1757 and #1735
Summarize your change.
This adds the ability to run processes using systemd-run which starts them in it's own cgroup. Logs from the process is read from journald instead of piping the output.
This should still be considered an experimental feature.