Skip to content

[Aikido] Fix 4 security issues in axios, lodash, thirdweb and 1 more #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aikido-autofix wants to merge 1 commit into from
Closed

[Aikido] Fix 4 security issues in axios, lodash, thirdweb and 1 more #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@
},
"packageManager": "pnpm@9.4.0",
"lint-staged": {
"**/*.{js,jsx,ts,tsx,json,css,scss,md}": ["biome check --write"]
"**/*.{js,jsx,ts,tsx,json,css,scss,md}": [
"biome check --write"
]
},
"devDependencies": {
"@arethetypeswrong/cli": "^0.16.4",
Expand All @@ -37,7 +39,10 @@
"image-size@>=1.1.0 <1.2.1": ">=1.2.1",
"elliptic@<6.6.0": ">=6.6.0",
"on-headers@<1.1.0": ">=1.1.0",
"tmp@<=0.2.3": ">=0.2.4"
"tmp@<=0.2.3": ">=0.2.4",
"axios@<=1.13.5": "1.13.5",
"lodash@<=4.17.23": "4.17.23",
"js-yaml@<=3.14.2": "3.14.2"
Copy link

@cursor cursor bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overrides use exact pins instead of >= ranges

Low Severity

All 13 existing pnpm overrides in this file use >= range syntax for the replacement version (e.g., ">=0.2.4"), but the three new overrides for axios, lodash, and js-yaml use exact version pins (e.g., "1.13.5"). This inconsistency means that when a transitive dependency resolves to a vulnerable version, the override will force it to exactly the current fix version rather than allowing resolution to any newer patched release. Using ">=1.13.5", ">=4.17.23", and ">=3.14.2" would match the established pattern and automatically pick up future security patches.

Fix in Cursor Fix in Web

}
}
}
22 changes: 16 additions & 6 deletions packages/agw-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,22 @@
},
"typesVersions": {
"*": {
"connectors": ["dist/types/exports/connectors.d.ts"],
"privy": ["dist/types/exports/privy.d.ts"],
"thirdweb": ["dist/types/exports/thirdweb.d.ts"]
"connectors": [
"dist/types/exports/connectors.d.ts"
],
"privy": [
"dist/types/exports/privy.d.ts"
],
"thirdweb": [
"dist/types/exports/thirdweb.d.ts"
]
}
},
"files": ["dist", "src", "package.json"],
"files": [
"dist",
"src",
"package.json"
],
"dependencies": {
"@abstract-foundation/agw-client": "workspace:*"
},
Expand All @@ -61,8 +71,8 @@
"@tanstack/react-query": "^5",
"react": ">=18",
"secp256k1": ">=5.0.1",
"typescript": ">=5.0.4",
"thirdweb": "^5.72.0",
"typescript": ">=5.0.4",
"viem": "^2.37.0",
"wagmi": "^2.17.5"
},
Expand All @@ -78,7 +88,7 @@
"@wagmi/core": "2.22.1",
"react": ">=18.3.1",
"react-dom": ">=18.3.1",
"thirdweb": "^5.68.0",
"thirdweb": "5.93.5-nightly-b51157c0ff17e9535029fc8790cfa8538d1c995f-20250326000337",
Copy link

@cursor cursor bot Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nightly build pinned as thirdweb devDependency

Medium Severity

The thirdweb devDependency was changed from a stable semver range "^5.68.0" to a specific nightly build "5.93.5-nightly-b51157c0ff17e9535029fc8790cfa8538d1c995f-20250326000337". Nightly builds are inherently unstable, may be removed from the registry, and aren't intended for committed dependencies. Stable thirdweb releases well beyond 5.93.x exist and would be appropriate here. This looks like a testing artifact that was accidentally included in the PR.

Fix in Cursor Fix in Web

"viem": "^2.37.0"
},
"peerDependenciesMeta": {
Expand Down
Loading
Loading