-
Notifications
You must be signed in to change notification settings - Fork 0
spark 3.5.5 #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spark 3.5.5 #122
Conversation
JaCoCo code coverage report - scala:2.11 - spark:2.4
|
JaCoCo code coverage report - scala:2.12 - spark:3.3
|
lazy val spark33 = "3.3.2" | ||
lazy val spark32 = "3.2.4" | ||
lazy val spark33 = "3.3.2" | ||
lazy val spark35 = "3.5.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still, don't we want to build it also for Spark 3.4 ? Since it's OSS used across many projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's necessary. And by that logic I would have to add few additional versions (both lower and higher).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what happens if someone is using Spark 3.4 in their project? What would happen if we are using it on some of our major projects? Isn't it the same scenario as for this 3.5.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's been added, hope it's alright finally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Added support for Spark 3.4.x and 3.5.x