Skip to content

Conversation

salamonpavel
Copy link
Collaborator

@salamonpavel salamonpavel commented Oct 2, 2025

Added support for Spark 3.4.x and 3.5.x

Copy link

github-actions bot commented Oct 2, 2025

JaCoCo code coverage report - scala:2.11 - spark:2.4

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Oct 2, 2025

JaCoCo code coverage report - scala:2.12 - spark:3.3

There is no coverage information present for the Files changed

lazy val spark33 = "3.3.2"
lazy val spark32 = "3.2.4"
lazy val spark33 = "3.3.2"
lazy val spark35 = "3.5.5"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still, don't we want to build it also for Spark 3.4 ? Since it's OSS used across many projects

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary. And by that logic I would have to add few additional versions (both lower and higher).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what happens if someone is using Spark 3.4 in their project? What would happen if we are using it on some of our major projects? Isn't it the same scenario as for this 3.5.x?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's been added, hope it's alright finally

Copy link
Collaborator

@lsulak lsulak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@salamonpavel salamonpavel merged commit 8d24e64 into master Oct 6, 2025
4 checks passed
@salamonpavel salamonpavel deleted the feature/spark355 branch October 6, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants