Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail when unknown placeholder received #115

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Do not fail when unknown placeholder received #115

merged 7 commits into from
Nov 25, 2024

Conversation

miroslavpojer
Copy link
Collaborator

  • ActionInput now can hold static values.
  • Improved unknown placeholder logic for their detection and removal.

Release Notes:

  • Action no longer fails when unknown placeholders are received.
  • Unknown placeholders are removed from the configuration.

@miroslavpojer
# Do not fail when unknown placeholder received
01078ba 
- ActionInput now can hold static values.
- Improved unknown placeholder logic for detection and removing of them.
@miroslavpojer miroslavpojer self-assigned this Nov 22, 2024
@miroslavpojer miroslavpojer added the enhancement New feature or request label Nov 22, 2024
MobiTikula
MobiTikula reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to my comments.

release_notes_generator/action_inputs.py Show resolved Hide resolved
release_notes_generator/action_inputs.py Outdated Show resolved Hide resolved
release_notes_generator/utils/utils.py Show resolved Hide resolved
tests/test_action_inputs.py Outdated Show resolved Hide resolved
tests/test_action_inputs.py Outdated Show resolved Hide resolved
tests/utils/test_utils.py Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have conflicts in this PR, solve it and I have no more comments for this PR.

@MobiTikula MobiTikula self-requested a review November 25, 2024 13:09
MobiTikula
MobiTikula approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@miroslavpojer miroslavpojer merged commit 9191d81 into master Nov 25, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/do-not-fail-with-unknown-placeholder branch November 25, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobiTikula MobiTikula MobiTikula approved these changes

@benedeki benedeki Awaiting requested review from benedeki

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miroslavpojer @MobiTikula