Replace SR-based plot cost recalculation with LCV pattern; fix serial…#43
Merged
Conversation
… status reset on handover Plot cost recalc now mimics ERPNext's Landed Cost Voucher internals (cancel/resubmit SLEs with via_landed_cost_voucher=True) instead of direct db.set_value, avoiding Stock Reconciliation's broken serial handling in v15. Handover serial fix simplified: instead of cancelling all SRs for the LA, reset only the one serial's status/warehouse metadata so DN validation passes without touching other plots. (cherry picked from commit 16dc393)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #42 to
version-15.Plot cost recalc now mimics ERPNext's Landed Cost Voucher internals (cancel/resubmit SLEs with via_landed_cost_voucher=True) instead of direct db.set_value, avoiding Stock Reconciliation's broken serial handling in v15.
Handover serial fix simplified: instead of cancelling all SRs for the LA, reset only the one serial's status/warehouse metadata so DN validation passes without touching other plots.