Skip to content

Deprecate SpacecraftSystem BSK module #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

schaubh
Copy link
Contributor

@schaubh schaubh commented May 22, 2025

  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

The SpacecraftSystem dynamic object allowed multiple spacecraft objects to be perfectly rigidly connected. however, this concept was never fully completed. Plus, we have now more flexible manners to connect spacecraft objects using the constraint effector.

Verification

Ran all unit tests after doing the depreciation warning and the warnings showed up as expected. Next, updated the unit tests to silence the expected deprecation warnings. The warnings will show up when the 1 year grace period ends.

Documentation

Added release notes and documentation built without issues.

Future work

None

@schaubh schaubh requested a review from Mark2000 May 22, 2025 20:50
@schaubh schaubh self-assigned this May 22, 2025
@schaubh schaubh requested a review from a team as a code owner May 22, 2025 20:50
@schaubh schaubh added this to Basilisk May 22, 2025
@schaubh schaubh added the enhancement New feature or request label May 22, 2025
@schaubh schaubh force-pushed the feature/deprecate_SpacecraftSystem branch from a688494 to 385c428 Compare May 23, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants