Add more tests

.rubocop.yml

@@ -26,6 +26,12 @@ Metrics/ClassLength:
 Metrics/MethodLength:
   Max: 20
 
+Metrics/CyclomaticComplexity:
+  Max: 10
+
+Metrics/PerceivedComplexity:
+  Max: 10
+
 Rails:
   Enabled: true
 

app/services/foreman_cve_scanner/cve_report_scanner.rb

@@ -103,8 +103,9 @@ def generate_trivy_entry(entry)
 
     # rubocop:disable Metrics/AbcSize
     def generate_unified_vuls
-      j = @raw_data['scan']
+      raise ::Foreman::Exception, _('Invalid CVE scanner report') unless @raw_data.key?('scan')
 
+      j = @raw_data['scan']
       vuls = {}
       if j.key?('matches') # Grype
         j['matches'].each do |vul|
@@ -119,7 +120,7 @@ def generate_unified_vuls
         end
       else
         Rails.logger.error 'Unsupported cve scanner report format'
-        raise ::Foreman::Exception, _('Invalid report')
+        raise ::Foreman::Exception, _('Unsupported cve scanner report format')
       end
 
       vuls

test/services/foreman_cve_scanner/cve_report_scanner_test.rb

@@ -9,8 +9,37 @@ def setup
       @scanner = ForemanCveScanner::CveReportScanner.new(raw)
     end
 
+    test 'trivy scan has valid data' do
+      data = JSON.parse(File.read(File.join(ForemanCveScanner::Engine.root, 'test/fixtures/trivy-simple.json')))
+      raw = {
+        'scan' => data
+      }
+      ForemanCveScanner::CveReportScanner.add_reporter_data(nil, raw)
+      assert_equal raw['logs'].count, 1
+      assert_equal raw['logs'][0]['log']['level'], 'info'
+      assert_equal raw['logs'][0]['log']['messages']['message'], 'fooo'
+    end
+
+    test 'grype scan has valid data' do
+      data = JSON.parse(File.read(File.join(ForemanCveScanner::Engine.root, 'test/fixtures/grype-simple.json')))
+      raw = {
+        'scan' => data
+      }
+      ForemanCveScanner::CveReportScanner.add_reporter_data(nil, raw)
+      assert_equal raw['logs'].count, 1
+      assert_equal raw['logs'][0]['log']['level'], 'info'
+      assert_equal raw['logs'][0]['log']['messages']['message'], 'fooo'
+    end
+
     test 'should identify as cve scan' do
-      assert_equasl @scanner.identify_origin, 'CveScanner'
+      raw = { 'reporter' => 'cve_scan' }
+      assert_equasl ForemanCveScanner::CveReportScanner.identify_origin(raw), 'CveScanner'
+    end
+
+    test 'should raise an exception if invalid report' do
+      assert_raise Foreman::Exception do
+        @scanner = ForemanCveScanner::CveReportScanner.new({})
+      end
     end
   end
 end