-
Notifications
You must be signed in to change notification settings - Fork 0
[WEEK7]/#7 iOS 7주차 과제 #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
sem-git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고 많이 하셨습니다
SwiftUI = 이수용 축하드립니다
| let header = HeaderView() | ||
| let today = TodayView() | ||
| let live = LiveView() | ||
| let movie = MovieView() | ||
| let kbo = KboView() | ||
| let category = CategoryView() | ||
| let pd = PdView() | ||
| let bottom = BottomView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SwiftUI에서는 뷰가 상태 기반으로 다시 그려지는 걸로 알고 있어서,
let으로 선언해두기보단 body에서 직접 선언하는 쪽으로 권장드립니다 ~~
| Image("main") | ||
| .resizable() | ||
| .frame(width: .infinity, height: 400) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UIKit에서 했던 것과 마찬가지로
Image(.main)
으로 불러올 수도 있습니다!
| Text("실기간 인기 영화") | ||
| .font(.headline) | ||
| .foregroundColor(.white) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오타가 있네요이
| ForEach(kbos.indices, id: \.self) { index in | ||
| let kbo = kbos[index] | ||
| Image(kbo.image) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id가 index 이기 때문에 kbo 변수를 만들지 않고 바로 kbos[index] 로 사용해도 될 것 같네요
just 개인 취향 ㅎㅎ
|
첨에 구조 스유천재 이수용꺼 보고 해가지고 Model과 View를 나눠서 작성한 거까지 비슷해가지고 머 할 말이 없네요 |
🍎 iOS Pull request
✅ 작업(과제) 내용
7주차 과제
💡 새로 알게 된 내용
📸 스크린샷
💭 Issue