Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core_cm33.h #1254

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

AlbertHuang-CPU
Copy link
Contributor

Correct a typo.

Correct a typo.
@JonatanAntoni
Copy link
Member

@AlbertHuang-CPU, thanks for pointing this out. We need to be carefull in renaming struct members. This can easily break exiting user applications which should be avoided as much as possible.

Copy link
Member

@JonatanAntoni JonatanAntoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All touched files needs to receive an update to their header information (i.e. file date and version).

@ARM-software ARM-software deleted a comment from grasci-arm Jun 23, 2022
@JonatanAntoni
Copy link
Member

@AlbertHuang-CPU, are you going to finish this patch?

@AlbertHuang-CPU
Copy link
Contributor Author

Hi, what need to do? to update the file date or to resolve conversation in the codes, or?

@jkrech
Copy link
Collaborator

jkrech commented Jun 24, 2022

Yes, please.

@JonatanAntoni
Copy link
Member

Outdated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants