include/cmsis_gcc.h: only read define if it exists #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If CMSIS is used on a cortex-m core, __CORTEX_M will be defined to be the correct core version, while __CORTEX_SC will be undefined. If CMSIS is used on a ARM SecureCore core, __CORTEX_SC will be defined to be the correct core version, while __CORTEX_M will be undefined. Thus, only one of the two defines will exists at a time. In order to avoid compiler warnings, this patch adds checks for the existence of the defines before accessing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am getting some compiler warnings from
gccwhen using CMSIS headers in aCortex-M0 project, e.g.
See also roboterclubaachen/xpcc#52.
This patch should fix this issue for users of cortex-m as well as ARM SecureCore cores.
It has the following underlying assumptions:
__CORTEX_Mwill be defined to be the correct core version, while__CORTEX_SCwill be undefined.__CORTEX_SCwill be defined to be the correct core version, while__CORTEX_Mwill be undefined.In order to avoid compiler warnings, this patch adds checks for the existence of the defines before accessing them.