Addition of re-projection to a common observer #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulJWright
changed the title
PaulJWright
commented
Nov 30, 2023
Comment on lines
+6
to
+7
|
|
||
|
|
samaloney
reviewed
Dec 4, 2023
| from astropy.coordinates import SkyCoord | ||
|
|
||
|
|
||
| def reproject_instrument( |
Contributor
There was a problem hiding this comment.
Names are hard but a think should rename this changes scale and distance of observer of a map using reproject it not the full retroject? Should prob also support the reproject keywords.
| 0 * u.arcsec, | ||
| 0 * u.arcsec, | ||
| frame="helioprojective", | ||
| rsun=sunpy_map.reference_coordinate.rsun, |
Contributor
There was a problem hiding this comment.
Have you checked if the rsun value in the reprojected maps is scaled properly, I assume it is but good to check. I know its a draft but some tests would be good later
Member
Author
There was a problem hiding this comment.
Yeah, this is a good plan. I am not sure if this is the way to do it, but a start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition of a function to reproject
sunpy.map.Mapobjects to a common observer.Leaving this as a draft, but the idea is that this would end up closing #5
Closes #5