Continuum test #191
Merged
Continuum test #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d N2. Also padded inproperly sized submaps using np.pad.
…Passes tests locally.
Refactored tests into separate file within testing folder, created te…
…_flare_check can work properly
…me series test data from .parq to .ecsv
Category splitting
samaloney
requested changes
Aug 15, 2025
Contributor
samaloney
left a comment
samaloney
left a comment
There was a problem hiding this comment.
Look good - just a few small suggestions, questions.
arccnet/visualisation/data.py
Outdated
| aia_map = np.zeros(hmi_map.data.shape) | ||
| ax = fig.add_subplot(nrows, ncols, i + 1) | ||
| ax.imshow(np.sqrt(aia_map.data), cmap=f"sdoaia{wv}") | ||
| ax.imshow(np.sqrt(aia_map.data), cmap=cmap) |
Contributor
There was a problem hiding this comment.
Why take the sqrt of 0? in fact I think you can just create and empty plot and set the text.
… frames once anim was plotted, and skip bad runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed HMI no limb dark continuum replacement of AIA 4500 Å, added some functionality for tracking empty drms dataframes but this is WIP.