Category splitting #185
Merged
Category splitting #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d N2. Also padded inproperly sized submaps using np.pad.
samaloney
requested changes
Jul 21, 2025
Contributor
samaloney
left a comment
samaloney
left a comment
There was a problem hiding this comment.
Looks pretty good, just some minor comments and need tests for the functions at least.
| """ | ||
| selection = [] | ||
| for type in types: | ||
| subtable = table[table["category"] == type] |
Contributor
There was a problem hiding this comment.
Since the input just an astroy table this columns name should be parameter also need some tests.
…Passes tests locally.
Refactored tests into separate file within testing folder, created te…
…_flare_check can work properly
samaloney
reviewed
Aug 13, 2025
samaloney
reviewed
Aug 13, 2025
samaloney
reviewed
Aug 13, 2025
samaloney
reviewed
Aug 13, 2025
samaloney
reviewed
Aug 13, 2025
samaloney
reviewed
Aug 13, 2025
…me series test data from .parq to .ecsv
samaloney
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the data prep function to check and split both flares and active regions for positive and negative data, split into 4 categories. F - positive case, flare occurs after run. N - negative case, no flare after run. 1 - no flares during run. 2 - flares during run.
Added padding function to ensure all frame sizes the same.