Refactor code for updated dependancies and add continuum #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samaloney
commented
Jul 16, 2025
samaloney
commented
- Started off trying to allow either only MDI or MDI but that was a night more
- Decided instead to update as is and try to add continuum
edoardolegnaro
approved these changes
Jul 18, 2025
DanGass
reviewed
Jul 21, 2025
Contributor
There was a problem hiding this comment.
Do you have any idea where this might manifest if it does?
Contributor
Author
There was a problem hiding this comment.
You mean line 111, it ends up being read in as a str and we need it as a number I guess the concern is what if it doesn't end up and int. I will set a break point and see but I think should be ok.
DanGass
approved these changes
Jul 21, 2025
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.