Mosaic test #181
Merged
Mosaic test #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o allow for quick visual inspection of each set. Reduced number of cores from 6 to 4.
Contributor
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
samaloney
requested changes
Jun 25, 2025
| return fits_path | ||
|
|
||
|
|
||
| def vid_match(table, name, path): |
Contributor
There was a problem hiding this comment.
This would probably be better as 3 functions:
- a function to plot a "batch" of data or X maps in a certain layout (dealing) with missing maps
- A function to make a bunch of plots based on the input table
- A function to turn the plots into a video
Also did you look at using matplotlib for the video part or why use openCV - I guess we already have a dependency on it so no big deal either way.
…_match, as well as unlocalising reference to srs and hek parq files, moving copies to catalogs folder.
…ew version of precommit.
…evaluations. Changed train_utils test to validate to avoid pytest issues.
samaloney
approved these changes
Jul 9, 2025
Contributor
samaloney
left a comment
samaloney
left a comment
There was a problem hiding this comment.
Looksg good, maybe move mosaic_plot and ,mosaic_vid to arccnet/visualisation/data where most of the plotting code is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to produce animation and pack L4 files automatically. Incorporated some of Eduardo's feedback, more in next PR.