Maintenance of project configuration and updates #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samaloney
commented
Apr 17, 2025
samaloney
commented
- Move configs to individual files (.isort, pytest.ini, etc)
- Move all package information and build into project.toml
- Remove setup.cfg
- Update dependancies
* Move configs to individual files * Move all package information and build into project.toml * Update dependancies
samaloney
changed the title
edoardolegnaro
approved these changes
Apr 17, 2025
DanGass
approved these changes
Apr 17, 2025
Contributor
Author
|
Ah here @DanGass and @edoardolegnaro the tests aren't even passing! |
samaloney
commented
Apr 17, 2025
| "Topic :: Scientific/Engineering :: Physics" | ||
| ] | ||
| dependencies = [ | ||
| "sunpy[all]~=6.1", |
Contributor
Author
There was a problem hiding this comment.
Not sure if we want to specify different min version of numpy?
Contributor
|
The tests aren't passing becuase it is python 3.9, and astropy 7 requires python 3.11 at least, so since we're updating should we update the tests to a higher python version? |
Contributor
Author
|
Yea I forget to update the CI/TOX but my point was prob best to not approve until the tests pass |
samaloney
commented
Apr 17, 2025
| "packaging>=23.0", | ||
| "scikit-learn~=1.3", | ||
| "platformdirs~=3.9", | ||
| "pyarrow", |
Contributor
Author
There was a problem hiding this comment.
So was running into issues with pyarrow and ml-flow, no clue where ml-flow is being installed I can only guess comet-ml so had to remove the version.
Contributor
|
Ok sorry, I was under the impression that if versions had changed the tests would necessarily fail. |
DanGass
referenced
this pull request
in DanGass/ARCCnetBackup
Apr 25, 2025
Maintenance of project configuration and updates (#167)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.