FWF-4762 Upgrade to Version 5.2.2 #1
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lectboxes with url type is failed to load options
… value property is not set
…ntentionally hidden (formio#5906) * validateWhenHidden respects all kinds of visibility * add clearOnHide: false to fix test
* validate current page on wizard change * add tests * fix tests * Specify correct flag for form validation after failed wizard submission - this.validate() is only called in onChange() if the form previously failed to submit. Because of this, the form will already be dirty, so it makes sense to reiterate this by passing dirty: true instead of false. --------- Co-authored-by: Blake Krammes <[email protected]>
…tings saving due to validation configured in logic
…bsequent form interaction when current page has no errors (formio#5922) * FIO-9350 Wizard: Show all form errors consistently after failed submission - Show all form errors on page without required fields after failed submission - Show all form errors on page with required fields after failed submission and after interacting with the page * FIO-9350 Wizard: Persist form errors if submission failed - While showErrors worked as expected (defined in Webform), this.errors (get errors()) in Wizard was not persisting all the form errors after a failed submission * FIO-9350 Wizard: Clean up dup helper fns in tests - Consolidate most link navigation to one global helper fn * FIO-9350 Wizard: Add test for maintaining form errors after failed submit - Show form-level errors after failed submission even when the current page has no errors * FIO-9350 Wizard: Simplify async flow for flaky test
…me messed up during builder mode.
* 5.x - FIO-8426: changes required for eSignature * added types and description * refactored types * added description for renderModalPreview returned value
…g the correct path.
… in wizards are not properly highlighting when you click the error link. (formio#6189) * FIO-10425: Fixed issues where fields with errors in nested forms within wizards are not properly highlighting when you click the error link. * Fixed some test issues. * Remove metadata from unit tests for nested forms. --------- Co-authored-by: John Teague <[email protected]>
…ssue where validation does not work well for components inside conditional nested form'
…nge to pagination styling'
…ssue where front validation doesnot work for nested form components inside nested wizard'
* test commit * fixed test
…ssue where WizardBuiler is not fully destroyed and keeps listening to saveComponent event leadign to unexpected behaviour'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FWF-4762
Description
What changed?
Note
Most of the changes here are from the upstream
formiorepo. To see the additional changes I added to get this package working withforms-flow-ai, you can run the following command:Or view the output file:
formio-js-diff.txt
For readability, copy paste the output into a git-diff visualizer
Dependencies
How has this PR been tested?
Checklist: