feat: API validation & server-side rate limiting#654
Merged
Emmzyemms merged 2 commits intoJun 29, 2026
Merged
Conversation
- Cap /api/upload at MAX_FILES_PER_REQUEST=10; return 400 if exceeded - Validate /api/jobs/[id] id format (alphanumeric/UUID, max 64 chars); return 400 on invalid - Add server-side in-memory token bucket rate limiter (applyRateLimit) - Return X-RateLimit-Limit, X-RateLimit-Remaining, Retry-After on 429 - Add integration tests covering all acceptance criteria (16 tests) Closes ANYTECHS#499
|
@fridaypetra55-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499
Summary
This PR strengthens the API by adding request validation and server-side rate limiting. It enforces upload limits, validates job IDs before processing requests, implements an in-memory token bucket rate limiter, exposes rate limit headers, and adds comprehensive integration tests covering all acceptance criteria.
Changes
Limited
/api/uploadto a maximum ofMAX_FILES_PER_REQUEST(10) files per request.Return HTTP 400 Bad Request when the upload limit is exceeded.
Added validation for
/api/jobs/[id]to accept only valid alphanumeric or UUID identifiers with a maximum length of 64 characters.Return HTTP 400 Bad Request for invalid job IDs.
Implemented a server-side in-memory token bucket rate limiter via
applyRateLimit.Added rate limit response headers:
X-RateLimit-LimitX-RateLimit-RemainingRetry-After(on HTTP 429 responses)Improved API resilience against malformed requests and excessive traffic.
Testing
Added 16 integration tests covering:
MAX_FILES_PER_REQUEST.X-RateLimit-Limit,X-RateLimit-Remaining, andRetry-Afterresponse headers.Checklist
main