Fixed EB data for anisotropic grids: boundary centroid, normal vector (backward compatible) #4357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
bcent
) inset_eb_data
called withinbuild_cells
, and the normal vector (normal
) inEBToPVD::EBToPolygon
.Additional background
bcent
, normalized using a single parameter ((nx*dx[0])*(nx*dx[0]) + (ny*dx[1])*(ny*dx[1]) + (nz*dx[2])*(nz*dx[2])
) for all x-, y-, and z-components, results in inappropriate non-dimensional values. The proper physical coordinates can be calculated in user-end code (e.g. ERF) by re-normalizing thebcent
parameters.Level::coarsenFromFine
, thebcent
from the finest grid is used to construct coarse EB data. This process produces incorrectbcent
on coarse grids, which cannot be recovered in user-end code. Therefore, I propose this PR.@nataraj2 I am submitting a PR to fix normalization of
bcent
for anisotropic grids. So far, I have used thebcent
as it is, by renormalizing it in ERF. However, I encountered an issue that cannot be fixed from ERF when coarsening the EB data from the fine grid to coarse grids. I discussed this issue with @WeiqunZhang.Checklist
The proposed changes: