Repository navigation
Fix HumanEval assistant-prefix continuation - #118
Merged
haofrank merged 2 commits intoOct 8, 2026
Merged
Conversation
amd-nithya
requested review from
a team,
haofrank and
sinarafati-amd
as code owners
October 7, 2026 23:49
haofrank
reviewed
Oct 8, 2026
haofrank
left a comment
Member
There was a problem hiding this comment.
Found two regressions in the HumanEval execution path. Related local tests passed (211); the lm-eval runtime test module was skipped because lm_eval is not installed locally. No GPU validation was performed.
haofrank
self-requested a review
October 8, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/v1/completionswhile rendering each model's chat template locally.lm_evalinvocation without HumanEval-specific flags.Why
humaneval_instructends its prompt with an assistant code prefix that the model must continue. The chat-completions path treats that prefix as an already completed message, while some local chat templates append end-of-message markers even when continuation is requested. The HumanEval-only compatibility launcher renders the model-native template locally and removes only the suffix after the final assistant content.Validation
248 passedacross the relevant benchmark, staging, and compatibility tests.bash -n, Python compilation, andgit diff --checkpassed.limit=5): GSM8K1.00, MMLU0.867, HellaSwag0.60, and HumanEval1.00(5/5).python -m lm_evalwithout--apply_chat_template; only HumanEval used the compatibility launcher.tokenized_requests=false, all five requests carried string prompts and HumanEval passed5/5.