Repository navigation
Improve Crystal lm-eval compatibility and HumanEval diagnostics - #115
Merged
Merged
Conversation
Split comma MAGPIE_EVAL_TASKS into separate --tasks argv words, skip InferenceX utils/evals --include_path for builtin names, keep EVAL_ONLY successful when accuracy_report.json is COMPLETED, and read pass@1,create_test for HumanEval. Co-authored-by: Cursor <cursoragent@cursor.com>
--include_path is a single global flag, but the stock InferenceX YAMLs suit only some tasks. gsm8k needs them because the shipped builtin still points at the bare `gsm8k` dataset id that newer huggingface_hub rejects. gpqa breaks with them because InferenceX's own `utils` package hides the task's process_docs. Resolve the stock directory into MAGPIE_EVAL_STOCK_INCLUDE_PATH instead of discarding it, split the requested tasks into a stock-include group and a plain group, run lm-eval once per group, and merge the two result files so downstream gates still see one results_conc<N>.json. MAGPIE_EVAL_STOCK_INCLUDE_TASKS overrides which tasks take the include and defaults to gsm8k. Suites that do not use the stock directory keep their single invocation. Co-authored-by: Cursor <cursoragent@cursor.com>
…CLI. An ERROR accuracy report with partial tasks must not become a successful EVAL_ONLY run, and --tasks must stay one comma-separated argument on lm-eval 0.4.8. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
amd-nithya
requested review from
a team,
haofrank and
sinarafati-amd
as code owners
October 5, 2026 18:09
…/eval-compat-test # Conflicts: # tests/test_eval_concurrency_scripts.py
haofrank
reviewed
Oct 5, 2026
haofrank
self-requested a review
October 6, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
python -m pytest tests/test_eval_concurrency_scripts.py tests/unit/modes/test_benchmarker.py