Repository navigation
Conversation
Align bare-metal pins, compatibility docs, and recommended lmsysorg/sglang-rocm image tags with the v0.5.20 release and patchless kernel_shape_tool profiling.
Use v0.5.20-rocm724-mi30x-20260919; mi35x stays on 20260920.
…-0.5.20 # Conflicts:
xiaofei-zheng
left a comment
There was a problem hiding this comment.
Blocking
1. The merge commit 415afca0 discards everything on main since the branch point — merging this PR reverts 6 merged PRs.
415afca03 ("Merge remote-tracking branch 'origin/main'") has a tree identical to its first parent:
$ git diff --stat 8949dd2e4 415afca03
(empty)
$ git diff --name-status d658bb480 415afca03 | wc -l
60
None of main's side of the merge survived. Everything merged between the branch point 6b4b4137 and d658bb48 would be rolled back by merging this PR: #1509 (ATOM detailed profiling), #1591 (preserve operator GEAK checkouts), #1589 (retire CHANGELOG.md), #1549 (ROCm 10 e2e), #1555 (single definition of agent default model ids), #1515 (catalog entry skill).
Concrete examples in the PR diff:
src/hyperloom/common/llm_config.py—DEFAULT_CLAUDE_MODEL/DEFAULT_CODEX_MODELand the backend-decides-the-last-rung resolution from #1555 are removed, andresolve_forge_llm_modelgoes back to a caller-supplieddefault="", so an OAuth-token run withCLAUDE_MODELunset posts an empty model id again.CHANGELOG.mdcomes back (+2286) anddocs/release-notes.mdloses 669 lines, reverting #1589..github/workflows/federated-skill.yml,scripts/tests/test_federated_skill_contract.py,examples/skills/hyperloom-workload-optimizer/SKILL.md,src/kernelforge/tests/test_rocpc_profile_discovery.pyare deleted.src/hyperloom/inference_optimizer/assets/install.sh(-160),rocpc_profile.py(-141),_workload_envs.py(-81) are rewound to their pre-mainversions.
This also silently drops the reason main currently pins 0.5.19: main's install_baremetal.sh/compatibility.rst state the pin sits at 0.5.19 because through 0.5.18 the HIP extra pinned compressed-tensors==0.15.0, capping torch below 2.11 and making ROCm 10 unresolvable. The 0.5.20 pin here is fine on that axis, but that constraint should be re-stated on top of current main, not erased.
CI is green because the branch tree is internally consistent with the old main — it does not catch the revert.
Please redo the integration (git merge origin/main from a clean branch, or rebase the three real commits onto current main) so the diff contains only the SGLang 0.5.18 → 0.5.20 change on top of main's current 0.5.19 state.
2. No docs/release-notes.md entry.
The validated default framework stack (SGLANG_REF, SGLANG_PRETEND_VERSION, recommended lmsysorg/sglang-rocm image tags, models.tsv, quick-start Dockerfile) is user-visible, and docs/release-notes.md "Unreleased" is where main carries such changes (#1580 added one for a comparable change). Add an entry, including the upgrade note that users on the v0.5.18-rocm724-* images need to move to v0.5.20-rocm724-*.
Checked
- Real PR commits (
5ee35eec,8949dd2e,6751302) reviewed line by line: docs/examples tag updates,install_baremetal.shpin +IMAGE_HINT,models.tsv, quick-startDockerfile, and the relaxedtest_baremetal_doc_version_consistency.py. Doc/asset tags are consistent across all nine touched files (mi30x-20260919/mi35x-20260920). SGLANG_REF=d158602ff1d2cb953196c95158c488d503d2470cresolves to the annotated tag objectv0.5.20(commit94602c9c2b), soSETUPTOOLS_SCM_PRETEND_VERSION_FOR_SGLANG=0.5.20matches. Worth confirminggit fetch --depth 1 origin <tag-object-sha>ininstall_sglang_from_sourcebehaves as expected, since the surrounding comment assumes a commit SHA.- Shape-discovery gate:
_server_patcher.pyroutes >= 0.5.18 to the no-patchkernel_shape_tool, so dropping the "patches fail on the tag" rationale is correct for 0.5.20.
Switch recommended lmsysorg/sglang-rocm tags to v0.5.20-rocm10-* (20260920) and align compatibility docs with ROCm 10.0.
|
Superseded: branch was rebuilt on current main (removed the bad merge that dropped main-side changes). A new PR follows. |
Summary
SGLANG_REF,SGLANG_PRETEND_VERSION, recommendedlmsysorg/sglang-rocm:v0.5.20-rocm724-*tags).kernel_shape_tool.Test plan
pytest src/hyperloom/inference_optimizer/tests/test_baremetal_doc_version_consistency.py