Repository navigation
Conversation
Pin the new scoring image, adapt SDK loading and task dependencies, and update all six evaluation-tool runtimes with matching documentation and regression coverage. Keep qualification pending for GPU ASan and the existing fused-MoE numerical failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MI355X default still uses ROCm 7.2, while the ROCm 10 image changes Python, Triton, FlyDSL and SDK library layout. This change selects the digest-pinned SGLang 0.5.20 / ROCm 10 image and updates the runner, all six optional evaluation-tool runtimes, affected tasks and documentation together.
This PR remains a draft with two qualification blockers:
Changes
Validation
Hardware: real AMD Instinct MI355X GPUs, with Docker/Slurm runs on Linux. The new runtime is SGLang 0.5.20, ROCm SDK 10.0.0, Python 3.12, PyTorch 2.11, Triton 3.8 and FlyDSL 0.3.2, pinned to
sha256:e20849665c105d389ef91d23c0dc73931aaa6f02056dd10e7b43e4f16c79df69.task_validatorPASS reports for their final task sources on MI355X.python3 -m pytest -q tests/eval_tools tests/test_rocm_sdk_runtime.py: 296 passed on Linux with the final tool/runtime code.make check-docker-runnerandmake check-perf-helperspassed.tests/test_mla_runtime_compat.pypassed on MI355X.Failed and incomplete controls remain failures or incomplete evidence. Runtime promotion remains unqualified, as recorded in the image lock and documentation. Raw reports and experiment artifacts are retained outside the repository.