Skip to content

feat(basket): Discover enrich, DISCOVER mode, latency slim - #63

Merged
ssd2658 merged 2 commits into
mainfrom
hotfix/basket-discover-enrich
Sep 7, 2026
Merged

feat(basket): Discover enrich, DISCOVER mode, latency slim#63
ssd2658 merged 2 commits into
mainfrom
hotfix/basket-discover-enrich

Conversation

@sahim99

@sahim99 sahim99 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds OpportunityMode.DISCOVER with slim opportunities (no composition/buyList).
  • Skips live price fetch and alternatives enrichment on Discover list path.
  • Enriches ETF symbol, category, returns, and sparkline for Discover UI.
  • Industry-grade overlap fast-path: skip symbol-price sets and refreshMissingAlternatives when skipPriceFetch.

Test plan

  • Local Maven clean install -DskipTests (JBR)
  • Unit tests: OpportunityMode, EnrichedEtfService, BasketEngineService
  • PROD Postman-style smoke: catalog + POST /opportunities mode=DISCOVER → 8 baskets, ~1.1s warm, composition null, returns present
  • Confirm new image rollout finishes (image pull was slow on worker)

Deploy

Helm rev attempted with tag basket-v3-prod-20260902-2685f00; gateway already serving Discover contract on prior warm pod.

Add OpportunityMode DISCOVER with slim responses, skip price/alternatives
work on the list path, and ETF returns enrichment for Smart Baskets UI.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 451170b4-3c1b-4889-bc72-c6a5ac09da10


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Regression coverage for the Discover latency path so shared price
resolution cannot silently return on the list API.

Co-authored-by: Cursor <cursoragent@cursor.com>
@sahim99
sahim99 requested a deployment to preprod-am-portfolio September 7, 2026 14:43 — with GitHub Actions Waiting
@sahim99
sahim99 requested a deployment to preprod-am-portfolio September 7, 2026 14:43 — with GitHub Actions Waiting
@ssd2658
ssd2658 merged commit e2ae0ff into main Sep 7, 2026
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants