fix(basket): industry-grade engine, substitutes, and review fixes

[sahim99]

Summary

• Industry-grade basket backend: create claim→reserve→persist→complete (no orphan 409), MISSING buys with includeHeld=true, Unknown-sector soft gates, batched ledger on holdings, priceQuality/priceAsOf, drafts harden (DuplicateKey, Number overrides, payload cap).
• Review ops: shared Kafka SASL props, config-driven idempotency TTL + draft max-limit, null stale Mongo timestamps, precompiled ISIN Patterns, relative e2e README paths.
• CI: preprod aligns with trade pipeline (am-portfolio-preprod, org GHCR, direct-deploy.yml @ main).

Review map (fixed in ffca258)

Thread	Fix
Kafka SASL under consumer only	Moved to spring.kafka.properties
Idempotency 24h hardcoded	basket.create.idempotency-ttl-seconds + index config
DRAFT_LIMIT=5	basket.drafts.max-limit
Stale timestamp = now	Mongo fallback leaves timestamp=null
Physical weight vs inventory	Planning-only comment; create ledger 409 before persist
ISIN String.matches	Static Patterns in EtfApiClient
Absolute e2e README paths	.\scripts\...

P0 / P1

• P0: create integrity, MISSING sizing, Unknown sectorial, drafts, apply price fail-open, review ops
• P1: holdings batch (no per-ISIN ledger N+1), price quality, ETF L1 TTL / skip poor enrich
• P2 (light): unique operationIds, final-preview alias docs, optional catalog write token

API contract notes

• Create: 409 before portfolio row; idempotent key claim IN_PROGRESS→COMPLETED
• Calc: MISSING always gap-fills when price+weight; priceWarnings
• Apply: Unknown sector does not hard-gate; prices fail-open
• Drafts: GET /drafts ≠ /{basketId}; DuplicateKey → merge 200

Test checklist

• BasketPortfolioCreateServiceTest (incl. over-alloc before persist)
• BasketEngineExclusiveSubstituteTest / BasketEngineServiceTest (Unknown not sectorial; MISSING buys)
• BasketDraftServiceTest + BasketControllerTest drafts route
• MarketDataServiceStaleBackfillTest

Preprod deploy note

Helm release am-portfolio-preprod; Argo owns image tags via gitops after CI publish.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 62052d78-9ccd-41c4-b928-250f4d4864fa

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ssd2658]

🔍 Senior Architectural & Code Quality Review for PR #57

Thank you for this PR! The latency improvements (batching ETF lookups, decomposing BasketEngineService into focused components, and adding the fail-open fallback) are great additions.

I have conducted a file-by-file review with a focus on hardcoded credentials/endpoints/paths, configuration management, data integrity, and operational reliability.

Please review the inline comments and suggestions below.