Repository navigation
fix: preserve stopped MCPs and reject ambiguous update recovery - #347
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and behavior
After #346, saving a description-only edit could start a stopped MCP. Ambiguous recovery JSON could also authorize another binary swap, restore an unrelated backup, or delete recovery evidence. This follow-up preserves MCP activation when edit requests omit activation fields and refuses unsupported or contradictory recovery evidence before filesystem changes.
Changes
Verification
Targeted regressions, including six independently discovered phase/State boundary counterexamples, pass. Frozen recovery package race tests, the full Go suite and build passed; the final MCP consistency delta additionally passed handler/MCP race tests and independent GET-to-edit regression tests. All 277 JS tests and shell syntax passed. Independent code review found no remaining blockers. Exact-head cross-platform CI is required before merge. No release or deployment is included.
Unreleased changelog covers both fixes. Design, compatibility constraints and phase verification: docs/feature/self-update-recovery-fixes.md. Invalid/unsupported JSON recovery records now require manual correction rather than guessed mutation; valid producer records remain supported.