Gymnasium#11
Open
Bpoole908 wants to merge 16 commits into
Open
Conversation
…ject is not None.
Updated from v2 to v4 to hopefully fix workflow error.
…es this. As such, env was wrapped twice in WrapFrame.
- Updated tests for new atari registration as well.
- When agent losses all lives then was_real_done is returned as true on reset only. If true, a normal reset is done. If False, no real reset is done and the game continues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm attempting to update the repo to use Gymnasium.
Below are some initial points for discuss:
setup.pyfile to install atari-py and roms using gymnasium.setup.pyfile. This was due to moviepy installing the latest version of imageio which would throw aValueError: Can't write images with one color channel. Not sure if anyone else can replicate this.env_wrappers.pyhave been updated. I used SB3 as a guide for some of the wrappers when updating to new gym API. Some of the existing wrappers have updated versions (e..g,FrameStackingandLazyFrames). For now I have tried to keep everything as close to what was original coded within this file.