Skip to content
This repository was archived by the owner on Oct 25, 2023. It is now read-only.

Fixed misleading Metric Log Filters code example #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed misleading Metric Log Filters code example #181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ custom:
barExceptions:
metric: barExceptions
threshold: 0
statistic: Minimum
statistic: Sum
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that Minimum is an incorrect statistic to use here, but i would argue that Maximum is more appropriate by definition:
Maximum is the highest value observed during the specified period.

So if we want to trigger an alert when there are more pattern matches than a given threshold, we need to look at the Maximum number of matches observed during the specified period.

Its counter-intuitive, but thats what i arrived at by trial and error

period: 60
evaluationPeriods: 1
comparisonOperator: GreaterThanThreshold
Expand Down