Use confirmed inputs for anchor transactions #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to use opportunistic package relay (with 1-parent-1-child) we must use confirmed inputs when funding our anchor transactions. This will also be a requirement when using v3 transactions. We also take this opportunity to honor the `require_confirmed_inputs` parameter set by our peer during `interactive-tx`.
t-bast
force-pushed
the
package-relay-confirmed-inputs
branch
from
e35ccd5 to
39afd22
Compare
pm47
reviewed
Mar 5, 2025
There was a problem hiding this comment.
We also take this opportunity to honor the require_confirmed_inputs parameter set by our peer during interactive-tx.
We previously filtered unconfirmed inputs at the filterInputs step. Why don't we take the opportunity to simplify getInputDetails/canUseInput? It saves a RPC call.
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/OnChainWallet.scala
Outdated
Show resolved
Hide resolved
eclair-core/src/main/scala/fr/acinq/eclair/blockchain/bitcoind/rpc/BitcoinCoreClient.scala
Outdated
Show resolved
Hide resolved
Now that we delegate this to `bitcoind`, we don't need to check for confirmations of our inputs ourselves.
Good point, I missed that, this is definitely worth removing! Done in 6a8c6e4 |
pm47
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use opportunistic package relay (with 1-parent-1-child) we must use confirmed inputs when funding our anchor transactions. This will also be a requirement when using v3 transactions. We leverage the newly added
minconfparameter tofundrawtransaction.We also take this opportunity to honor the
require_confirmed_inputsparameter set by our peer duringinteractive-tx.