Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the findroute, findroutetonode and findroutebetweennodes commands #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement the findroute, findroutetonode and findroutebetweennodes commands #21

wants to merge 4 commits into from

Conversation

claddyy
Copy link
Contributor

@claddyy claddyy commented Aug 17, 2023 •
edited
Loading

The implementations of these commands are added through this PR.
Code for autocompletion and unit tests, for the respective commands are also added.
To see the documentation of these commands, kindly refer : API Documentation

t-bast
t-bast reviewed Aug 18, 2023
View reviewed changes
src/nativeTest/kotlin/mocks/EclairClientMocks.kt Outdated
@@ -879,6 +891,18 @@ class DummyEclairClient(
]
}
"""
val validFindRouteToNodeResponse = """{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're only testing the case where format=nodeId, you need to also test the format=shortChannelId and format=full cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll cover them soon.

@claddyy
Copy link
Contributor Author

claddyy commented Aug 19, 2023

I've added the test for different cases, like format=nodeId and sshortChannelId as well in 9f6f5fa for the findroute command.
The build will fail right now, since I've modified the EclairClientMocks. I will update the remaining tests once you approve this particular change.
You can individually run the test right now. It's passing for me.

@t-bast
Copy link
Member

t-bast commented Aug 21, 2023

I will update the remaining tests once you approve this particular change.

I'm not sure what particular change you want me to review before finishing the work?
You should simply finish updating the tests and then I'll be able to review it?

@claddyy claddyy requested a review from t-bast August 31, 2023 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast Awaiting requested review from t-bast

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claddyy @t-bast