Skip to content

Use Context Predicates for Mixin Loading#774

Merged
ACGaming merged 7 commits into
ACGaming:mainfrom
WaitingIdly:loader-context-use
Dec 22, 2025
Merged

Use Context Predicates for Mixin Loading#774
ACGaming merged 7 commits into
ACGaming:mainfrom
WaitingIdly:loader-context-use

Conversation

@WaitingIdly

Copy link
Copy Markdown
Collaborator

changes in this PR:

  • fix a mixin accessor trying to load Minecraft, which is a client-only class, on the server (generates a warning).
  • use Predicate<Context> instead of BooleanSupplier for mixin loaders.
  • use Context to check if mods are loaded, replacing all loaded({modid} with c.isModPresent({modid}).
  • change isDev() to be part of the predicate.
  • change Coremods#isLoaded to just be Context#isModPresent checks directly, and remove now-unused Coremods

@what-the-diff

what-the-diff Bot commented Dec 22, 2025

Copy link
Copy Markdown

PR Summary

  • Removal of Certain Core Modifications
    A number of core modifications housed in the file Coremods.java were removed. This includes modifications known as OPENMODS, RANDOM_PATCHES, RENDERLIB, SPONGEFORGE, and SURGE. Simplifying this file can make the code easier to maintain and possibly increase efficiency.

  • Added Client-Side Mixin iniclusion
    An entry has been added to the mixins.vanilla.mod.accessors.json file to include UTMinecraftAccessor for client-side mixins. This entry can help improve the game's performance on client side by modifying its behaviors and interactions.

@ACGaming ACGaming merged commit d01549b into ACGaming:main Dec 22, 2025
1 check passed
@WaitingIdly WaitingIdly deleted the loader-context-use branch December 23, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants