Skip to content

Several BiblioCraft Fixes#773

Merged
ACGaming merged 13 commits into
ACGaming:mainfrom
WaitingIdly:more-bibliocraft
Dec 22, 2025
Merged

Several BiblioCraft Fixes#773
ACGaming merged 13 commits into
ACGaming:mainfrom
WaitingIdly:more-bibliocraft

Conversation

@WaitingIdly

Copy link
Copy Markdown
Collaborator

changes in this PR:

  • migrate most access transformers to accessor mixins that are always loaded if utMasterSwitchModIntegration is enabled.
  • change UTBreakableBedrockMixin from @Redirect to @WrapOperation, which means it no longer needs an AT.
  • make the UTItemArmorMixin for armor swapping ignore the Curse of Binding if the player is in creative mode (matching gui functionality).
  • fix the clipboard and atlas not rendering correctly if the player has set their main hand to left (default: true).
  • fix the armor stand not using the correct slots (numbers were flipped) and fix the slots only check armor instead of any valid item for that equipment slot (default: true).
  • fix the clipboard and catalog using the main hand instead of the hand enum, leading to them being able to delete the main hand item (default: true).
  • fix the armor stand not respecting the Curse of Binding in both the GUI and in-world interactions (default: true).
  • fix the fancy sign item rotation not matching what is displayed in the GUI and block rotation being rotated 90° in the GUI (default: true).
  • allow the printing press to properly use any dyeBlack - currently, you can insert it, but it doesnt actually process (default: true).
  • fix bibliocraft sounds not being registered and thus crashing on servers (default: true).
  • fix BiblioTileEntity implementing both IInventory and IItemHandler, leading to the method getStackInSlot (which both interfaces have) to be obfuscated away by IInventory, meaning anything that interacted with IItemHandler#getStackInSlot crashed (default: true).
  • fix bibliocraft not allowing item transfers properly (default: true).

a non-exhaustive set of links to various issues this fixes:
offhand: Nuchaz/BiblioCraft#575
left hand: Nuchaz/BiblioCraft#650, Nuchaz/BiblioCraft#585, Nuchaz/BiblioCraft#734, Nuchaz/BiblioCraft#720
fancy sign: Nuchaz/BiblioCraft#647
printing press: Nuchaz/BiblioCraft#559,
sound: Nuchaz/BiblioCraft#725, Nuchaz/BiblioCraft#701, xJon/The-1.12.2-Pack#171, Nuchaz/BiblioCraft#600, Nuchaz/BiblioCraft#611
IItemHandler#getStackInSlot: Nuchaz/BiblioCraft#678, Nuchaz/BiblioCraft#703, Nuchaz/BiblioCraft#671, rwtema/Extra-Utilities-2-Source#287, Nuchaz/BiblioCraft#693, Nuchaz/BiblioCraft#689, Nuchaz/BiblioCraft#554, Nuchaz/BiblioCraft#519, Nuchaz/BiblioCraft#601, Nuchaz/BiblioCraft#629, McJtyMods/RFTools#1886, Nuchaz/BiblioCraft#640, Nuchaz/BiblioCraft#635, GotoLink/RecipeHandler#31, Nuchaz/BiblioCraft#704

@ACGaming ACGaming merged commit fd98814 into ACGaming:main Dec 22, 2025
1 check passed
@WaitingIdly WaitingIdly deleted the more-bibliocraft branch December 23, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants