Better explaining ponder #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
you're welcome
marchc1
requested changes
Apr 30, 2025
Member
marchc1
left a comment
marchc1
left a comment
There was a problem hiding this comment.
Couple of things I want to note (and sorry for this being so late)
- I'm fine with the documentation you provided in README.md, but why replace the entire readme? Can you just add it at the bottom/a separate file?
- It would be neat if we could place those .lua files in lua/ponder/storyboards_cl, so they can also be interacted with in-game.
Other than that, looks good to me
With regards to 1.; you could probably just have links going to each individual .md file (like the quick reference and wiki .md files) within the readme on the top or something
1. README.md: Instead of replacing the original README, I've preserved the original content at the top and added the detailed documentation at the bottom. I've also added a "Documentation" section with links to all documentation files right after the original content. 2. Lua Files: I've moved both Ponder_Example.lua and Ponder_Template.lua to the lua/ponder/storyboards_cl/ directory so they can be interacted with in-game. The files are now available in both locations: *Root directory (original location) lua/ponder/storyboards_cl/ (new location for in-game interaction) 3. Documentation Links: All links in the README now point to the appropriate locations: *Wiki and Quick Reference links point to the .md files in the root directory *Example and Template links point to the .lua files in the lua/ponder/storyboards_cl/ directory
Contributor
Author
|
@marchc1 should all be done now |
Member
Looks good, again sorry it took so long for this really basic PR, completely forgot and I've been busy lately |
Member
|
sorry - ignore that, was trying to make it show as Approved on GitHub but it seems to not like doing that post-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you're welcome