Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions src/gatehouse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -715,24 +715,28 @@ function buildAbacPolicy<Sub, Res, Act, Ctx>(
action,
context,
}): Promise<PolicyEvalResult> => {
const conditionMet: boolean = await condition({
subject,
resource,
action,
context,
});
try {
const conditionMet: boolean = await condition({
subject,
resource,
action,
context,
});

if (conditionMet) {
return new GrantedAccessResult({
if (conditionMet) {
return new GrantedAccessResult({
policyType,
reason: 'Condition evaluated to true',
});
}

throw new Error('Condition evaluated to false');
} catch (error) {
return new DeniedAccessResult({
policyType,
reason: 'Condition evaluated to true',
reason: (error as Error)?.message || "Condition evaluated to false",
});
}

return new DeniedAccessResult({
policyType,
reason: 'Condition evaluated to false',
});
};

return Object.freeze({ name: policyType, evaluateAccess, condition });
Expand Down
19 changes: 19 additions & 0 deletions tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -898,3 +898,22 @@ describe("PermissionChecker", () => {
expect(result.isGranted()).toBe(false);
});
});

describe("Custom denied reasons", () => {
test("should return custom denied reason when access is denied", async () => {
const abacPolicy = buildAbacPolicy<object, object, object, object>({
condition: () => {
throw new Error("Access denied: A detailed reason for denial");
},
});

const result = await abacPolicy.evaluateAccess({
subject: {},
resource: {},
action: {},
context: {},
});
expect(result.isGranted()).toBe(false);
expect(result.reason).toBe("Access denied: A detailed reason for denial");
});
});