Added encrytion method #24
Conversation
CharithW
commented
Jan 8, 2018
CharithW
commented
- a task list item
- list syntax required
- normal formatting, @mentions, #1234 refs
- incomplete
- completed
| { | ||
| public class Encrypt | ||
| { | ||
| readonly string PasswordHash ="SampleHash"; |
There was a problem hiding this comment.
Inject the Secrets to the class via .net DI framework. Refer the code written Decrypt.cs
| { | ||
| byte[] plainTextBytes = Encoding.UTF8.GetBytes(plainText); | ||
|
|
||
| byte[] keyBytes = new Rfc2898DeriveBytes(PasswordHash, Encoding.ASCII.GetBytes(SaltKey)).GetBytes(256 / 8); |
| byte[] plainTextBytes = Encoding.UTF8.GetBytes(plainText); | ||
|
|
||
| byte[] keyBytes = new Rfc2898DeriveBytes(PasswordHash, Encoding.ASCII.GetBytes(SaltKey)).GetBytes(256 / 8); | ||
| var symmetricKey = new RijndaelManaged() { Mode = CipherMode.CBC, Padding = PaddingMode.Zeros }; |
There was a problem hiding this comment.
Use the corresponding types instead of var.
| cipherTextBytes = memoryStream.ToArray(); | ||
| cryptoStream.Close(); | ||
| } | ||
| memoryStream.Close(); |
There was a problem hiding this comment.
memoryStream closes automatically once the execution has done within the using statement. Not need to specifically close.
| } | ||
| } | ||
|
|
||
| static SymmetricAlgorithm CreateAlgorithm() |
There was a problem hiding this comment.
Consider changing the accessibility of the method and available as an instance method instead of static. You can change this to private SymmetricAlgorithm CreateAlgorithm() instead.
OR
reuse the same logic written on Decrypt.cs
| } | ||
| memoryStream.Close(); | ||
| } | ||
| string encrypted_text = Convert.ToBase64String(cipherTextBytes); |
There was a problem hiding this comment.
Consider returning the converted string instead of assigning to a local variable and returning the variable instance.
|
Noted and will add these changes |
| { | ||
| byte[] plainTextBytes = Encoding.UTF8.GetBytes(plainText); | ||
|
|
||
| byte[] keyBytes = new Rfc2898DeriveBytes(PasswordHash, Encoding.ASCII.GetBytes(SaltKey)).GetBytes(256 / 8); |
There was a problem hiding this comment.
I think the line is bit off indented? Applicable to several places.
There was a problem hiding this comment.
Just noticed that @kosalanuwan already pointed it out. Ignore my comment.
3 participants
