logging: query errors should not use debug level

7840vz · Sep 16, 2024 · f1a863f · f1a863f
1 parent 740e7ff
commit f1a863f
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/cmd/idrac_exporter/handler.go b/cmd/idrac_exporter/handler.go
@@ -53,7 +53,7 @@ func MetricsHandler(rsp http.ResponseWriter, req *http.Request) {
 
 	c, err := collector.GetCollector(target)
 	if err != nil {
-		errorMsg := fmt.Sprintf("Error instantiating metrics collector for host %s: %v\n", target, err)
+		errorMsg := fmt.Sprintf("Error instantiating metrics collector for host %s: %v", target, err)
 		log.Error(errorMsg)
 		http.Error(rsp, errorMsg, http.StatusInternalServerError)
 		return
@@ -63,7 +63,7 @@ func MetricsHandler(rsp http.ResponseWriter, req *http.Request) {
 
 	metrics, err := c.Gather()
 	if err != nil {
-		errorMsg := fmt.Sprintf("Error collecting metrics for host %s: %v\n", target, err)
+		errorMsg := fmt.Sprintf("Error collecting metrics for host %s: %v", target, err)
 		log.Error(errorMsg)
 		http.Error(rsp, errorMsg, http.StatusInternalServerError)
 		return

diff --git a/internal/collector/client.go b/internal/collector/client.go
@@ -458,25 +458,25 @@ func (client *Client) redfishGet(path string, res interface{}) error {
 	req.Header.Add("Accept", "application/json")
 	req.SetBasicAuth(client.username, client.password)
 
-	log.Debug("Querying url %q", url)
+	log.Debug("Querying %q", url)
 
 	resp, err := client.httpClient.Do(req)
 	if resp != nil {
 		defer resp.Body.Close()
 	}
 	if err != nil {
-		log.Debug("Failed to query url %q: %v", url, err)
+		log.Error("Failed to query %q: %v", url, err)
 		return err
 	}
 
 	if resp.StatusCode != 200 {
-		log.Debug("Query to url %q returned unexpected status code: %d (%s)", url, resp.StatusCode, resp.Status)
+		log.Error("Query to %q returned unexpected status code: %d (%s)", url, resp.StatusCode, resp.Status)
 		return fmt.Errorf("%d %s", resp.StatusCode, resp.Status)
 	}
 
 	err = json.NewDecoder(resp.Body).Decode(res)
 	if err != nil {
-		log.Debug("Error decoding response from url %q: %v", url, err)
+		log.Error("Error decoding response from %q: %v", url, err)
 		return err
 	}
 

diff --git a/internal/config/config.go b/internal/config/config.go
@@ -47,6 +47,8 @@ func readConfigFile(filename string) {
 	if err != nil {
 		log.Fatal("Invalid configuration file: %s: %s", filename, err.Error())
 	}
+
+	log.Info("Configuration file: %s", filename)
 }
 
 func ReadConfig(filename string) {