Renames numbers to digits and updates dependencies #12
+17
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Hey, and thanks for the contribution! The new dependencies are not compatible with Rust 1.70.
Could you remove the dependency update? Or change it so that compatible dependencies are installed?
|
Done. Any other changes please let me know. |
|
Thank you! Please change the version of the crate again since this is a breaking change. |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream they have renamed the numbers field to digits (see for example here). This PR simply does that renaming and also updates the dependencies.
In my particular case I have also done the renaming in the rockpass or the lesspass-client.