Added IRC string formatting to HTML conversion #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Added function that converts IRC string formatting code to its equivalent HTML code -Set sendMessage's optional parse_mode parameter to HTML
| @@ -64,11 +71,11 @@ var init = function(msgCallback) { | |||
| } | |||
|
|
|||
| if (message.user) { | |||
| message.text = '<' + message.user + '> ' + message.text; | |||
| message.text = '<' + message.user + '> ' + irc_to_html_format(message.text); | |||
There was a problem hiding this comment.
Surely if you're sending HTML tags in a message you'd want to escape where it shows the username of the person who talked? It might be mistaken as a tag.
There was a problem hiding this comment.
<username> will be interpreted as an XML tag and probably will end up being removed by telegram, same goes for user input that contains these characters. We need to escape all occurences of < and > first.
| } | ||
|
|
||
| logger.verbose('>> relaying to TG:', message.text); | ||
| tg.sendMessage(message.channel.tgChatId, message.text); | ||
| tg.sendMessage(message.channel.tgChatId, message.text, parse_mode=telegram.ParseMode.HTML); |
There was a problem hiding this comment.
This syntax does not exist in JavaScript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Added function that converts IRC string formatting code to its equivalent HTML code
-Set sendMessage's optional parse_mode parameter to HTML