Skip to content

add comments #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yagom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add comments #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions week5/ImageBoard/ImageBoard/AddAtricleViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ class AddArticleViewController : UIViewController {

@IBAction func setPhotoFromLibrary(_ sender: UITapGestureRecognizer) {

// 메서드 이름은 setPhotoFromLibray 인데, 텍스트 필트를 resign 시키는 기능이 들어있는 것은
// 차후에 예상치 못한 동작들을 유발할 가능성이 있어 보입니다.
// 예제라 크게 문제 없겠지만, 실전이라면 나중에 나 또는 다른사람이 내 코드를 운용할 때 문제가 발생할 여지가 있습니다.
titleField.resignFirstResponder()
let imagePickerController = UIImagePickerController()
imagePickerController.sourceType = .photoLibrary
Expand Down
2 changes: 2 additions & 0 deletions week5/ImageBoard/ImageBoard/SignUpViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ class SignUpViewController : UIViewController {
DispatchQueue.main.async {
switch result {
case .ok :
// viewControllers[0] 보다는 viewControllers.first 사용하기
// 빈 Array일 때 viewControllers[0]은 크래쉬가 날 수 있습니다.
let loginViewControllerVC = self.navigationController?.viewControllers[0] as? LoginViewController
loginViewControllerVC?.signUpSuccess = true
self.signUpSuccess = true
Expand Down