feat: Add Nginx support #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag-rajawat
force-pushed
the
feat-ngx-njs
branch
from
86a6689
to
b729367
Compare
PrimalPimmy
reviewed
Nov 5, 2024
There was a problem hiding this comment.
so we are commenting both configs (istio sidecar and njs) and letting the users decide? Would it be better to use just two separate config files for each of these? Or make it configurable elsewhere?
There was a problem hiding this comment.
Would it be better to use just two separate config files for each of these? Or make it configurable elsewhere?
If we have n integration sources, we'll need to maintain config files for each of those n sources. That's why we have chosen to use a slice for the receivers.
Signed-off-by: Anurag Rajawat <[email protected]>
Signed-off-by: Anurag Rajawat <[email protected]>
anurag-rajawat
force-pushed
the
feat-ngx-njs
branch
from
b729367
to
970bcf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Additional information for reviewers
Docs are in #24