Put new Stuff into auto#7
Merged
Merged
Conversation
* WIP: shooter * Entire launcher, belt, and kicker subsystems fixed + cleanup. NEEDS TO BE REVIEWED. This was 10x programmed in 40 minutes * style: formatting * fix: LIMITS_ENABLED is respected * fix: review comments * mabey? * fmt * style: formatting * fix: critical review comments * test button * constants for shooter velocity * fix alot of stuff * feat: convert to/from rotations * fixed log path * pid tuneing etc * fix * refactor: CAN bus instances abstracted from each subsystem * refactor: DeflectorIOVortex cleanup * refactor: deflector subsystem cleanup * style: formatting * refactor: use named constant for default CAN frequency (50hz) * style: formatting * refactor: turret subsystem cleanup * refactor: shooter subsystem cleanup * fix: refactor oversights * Add OPEN_LOOP PID slot definition for logging * docs: fix stale javadocs in new subsystems * feat: AutoLogOutput all target setpoints for subsystems * style: formatting * refactor: make it more obvious what commands do what follow commands never end, they take suppliers to commands stop once they reach the target * refactor: explicitly named constants for shooter * refactor: explicitly named constants for deflector * refactor: explicitly named constants for turret * style: formatting * fix: review comments * docs: add docs for entire PR/Launcher system * docs: style: formatting * fix: Rowan's issues * fix: minor logic errors * style: formatting --------- Co-authored-by: rkortlandt <rowankortlandt@otsegops.org>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.