-
Notifications
You must be signed in to change notification settings - Fork 49
update to camden #612
base: master
Are you sure you want to change the base?
update to camden #612
Conversation
|
AFAIR the new Axion is required to use with newer Gradle version (due to changes in Gradle) |
@SpringApplicationConfiguration(value = TestApplication.class, initializers = ConfigFileApplicationContextInitializer.class) | ||
@IntegrationTest("com.ofg.infra.microservice.track-activity.enabled = false") | ||
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, classes = TestApplication.class, | ||
value = "com.ofg.infra.microservice.track-activity.enabled = false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@RunWith(SpringJUnit4ClassRunner.class) | ||
@SpringApplicationConfiguration(value = TestApplication.class, initializers = ConfigFileApplicationContextInitializer.class) | ||
@ContextConfiguration(classes = TestApplication.class, | ||
initializers = ConfigFileApplicationContextInitializer.class) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why in two lines?
@@ -126,7 +103,7 @@ configure(srcSubprojects) { | |||
dependency "cglib:cglib-nodep:3.2.5" | |||
dependency "org.objenesis:objenesis:2.5.1" | |||
|
|||
dependencySet(group:'org.spockframework', version: '1.0-groovy-2.4') { | |||
dependencySet(group:'org.spockframework', version: '1.1-groovy-2.4-rc-4') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
micro-deps/build.gradle
Outdated
@@ -39,7 +39,7 @@ project(':micro-deps-root:micro-deps-jax-rs-jersey') { | |||
testCompile "org.springframework.boot:spring-boot-starter-test" | |||
testCompile "org.springframework.boot:spring-boot-starter-actuator" | |||
testCompile "org.springframework.boot:spring-boot-starter-jersey" | |||
testCompile "org.springframework.boot:spring-boot-starter-tomcat" | |||
testCompile "org.springframework.boot:spring-boot-starter-jetty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
@@ -22,7 +20,7 @@ import static com.ofg.config.BasicProfiles.TEST | |||
* @see ApplicationContext | |||
*/ | |||
@CompileStatic | |||
@WebAppConfiguration | |||
//@WebAppConfiguration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm?
@Value('${stubrunner.use-microservice-definitions:false}') boolean useMicroserviceDefinitions, | ||
@Value('${stubrunner.wait-for-service:false}') boolean waitForService, | ||
@Value('${stubrunner.wait-timeout:1}') Integer waitTimeout, | ||
@Value('${stubrunner.wa`it-timeout:1}') Integer waitTimeout, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure with that change?
@@ -90,10 +90,10 @@ class StubRunnerConfiguration { | |||
@Value('${stubrunner.stubs.suffix:stubs}') String stubsSuffx, | |||
@Value('${stubrunner.stubs.classifier:}') String stubsClassifier, | |||
@Value('${stubrunner.work-offline:false}') boolean workOffline, | |||
@Deprecated @Value('${stubrunner.skip-local-repo:true}') boolean skipLocalRepo, | |||
@Deprecated @Value('${stubrunnbatchStubRunnerer.skip-local-repo:true}') boolean skipLocalRepo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice name :)
fac41db
to
2d997aa
Compare
2d997aa
to
32ce342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If fixed acceptance tests
No description provided.