Skip to content
This repository has been archived by the owner on May 11, 2021. It is now read-only.

update to camden #612

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update to camden #612

wants to merge 1 commit into from

Conversation

mariuszs
Copy link
Collaborator

No description provided.

@mariuszs mariuszs requested review from szpak, maciekpe and twroniak March 31, 2017 12:53
@mariuszs mariuszs self-assigned this Mar 31, 2017
@szpak
Copy link
Collaborator

szpak commented Mar 31, 2017

Caused by: org.gradle.internal.service.UnknownServiceException: No service of type StyledTextOutputFactory available in ProjectScopeServices.

@szpak
Copy link
Collaborator

szpak commented Mar 31, 2017

AFAIR the new Axion is required to use with newer Gradle version (due to changes in Gradle)

@SpringApplicationConfiguration(value = TestApplication.class, initializers = ConfigFileApplicationContextInitializer.class)
@IntegrationTest("com.ofg.infra.microservice.track-activity.enabled = false")
@SpringBootTest(webEnvironment = SpringBootTest.WebEnvironment.NONE, classes = TestApplication.class,
value = "com.ofg.infra.microservice.track-activity.enabled = false")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RunWith(SpringJUnit4ClassRunner.class)
@SpringApplicationConfiguration(value = TestApplication.class, initializers = ConfigFileApplicationContextInitializer.class)
@ContextConfiguration(classes = TestApplication.class,
initializers = ConfigFileApplicationContextInitializer.class)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in two lines?

@@ -126,7 +103,7 @@ configure(srcSubprojects) {
dependency "cglib:cglib-nodep:3.2.5"
dependency "org.objenesis:objenesis:2.5.1"

dependencySet(group:'org.spockframework', version: '1.0-groovy-2.4') {
dependencySet(group:'org.spockframework', version: '1.1-groovy-2.4-rc-4') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -39,7 +39,7 @@ project(':micro-deps-root:micro-deps-jax-rs-jersey') {
testCompile "org.springframework.boot:spring-boot-starter-test"
testCompile "org.springframework.boot:spring-boot-starter-actuator"
testCompile "org.springframework.boot:spring-boot-starter-jersey"
testCompile "org.springframework.boot:spring-boot-starter-tomcat"
testCompile "org.springframework.boot:spring-boot-starter-jetty"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@@ -22,7 +20,7 @@ import static com.ofg.config.BasicProfiles.TEST
* @see ApplicationContext
*/
@CompileStatic
@WebAppConfiguration
//@WebAppConfiguration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm?

@Value('${stubrunner.use-microservice-definitions:false}') boolean useMicroserviceDefinitions,
@Value('${stubrunner.wait-for-service:false}') boolean waitForService,
@Value('${stubrunner.wait-timeout:1}') Integer waitTimeout,
@Value('${stubrunner.wa`it-timeout:1}') Integer waitTimeout,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure with that change?

@@ -90,10 +90,10 @@ class StubRunnerConfiguration {
@Value('${stubrunner.stubs.suffix:stubs}') String stubsSuffx,
@Value('${stubrunner.stubs.classifier:}') String stubsClassifier,
@Value('${stubrunner.work-offline:false}') boolean workOffline,
@Deprecated @Value('${stubrunner.skip-local-repo:true}') boolean skipLocalRepo,
@Deprecated @Value('${stubrunnbatchStubRunnerer.skip-local-repo:true}') boolean skipLocalRepo,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice name :)

@mariuszs mariuszs force-pushed the tech/update_to_camden branch 5 times, most recently from fac41db to 2d997aa Compare March 31, 2017 18:38
@mariuszs mariuszs force-pushed the tech/update_to_camden branch from 2d997aa to 32ce342 Compare April 3, 2017 08:08
Copy link
Collaborator

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If fixed acceptance tests

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants