Support Discord reply #1706
Support Discord reply #1706
Conversation
lekoOwO
force-pushed
the
discord-reply
branch
2 times, most recently
from
613cd5c to
b147cc9
Compare
|
@lekoOwO we already supported discord replies. What issues do you have with the current implementation? |
Um do we have one? |
|
So no message appears on telegram when using reply on discord? |
|
Replied message appears on telegram with no reply info just like other plain messages. |
|
@42wim discord has changed the way it handles replies, please merge it into master. |
|
+1 |
|
just ran into this issue on a new install, looking forward to this pr merged |
|
Works perfectly for me. |
|
Yesterday tested master branch without this merge requests. Replying from discord works fine in telegram. Don't understand why we need this change then. P.S. By bad. This pr is needed. |
|
@sleroq can you show us a screenshot? You might be misunderstanding what this PR does |
|
Without this change, a Discord user replying to someone is bridged as a normal message that's not a reply to Matrix and will have an empty reply on Telegram. This appears to work properly at least as a workaround for now. It would be really nice if matterbridge used structured replies across the bridge but perhaps it's unrealistic to expect that. |
lekoOwO
force-pushed
the
discord-reply
branch
from
b147cc9 to
b63eccd
Compare
|
Code Climate has analyzed commit b63eccd and detected 0 issues on this pull request. View more on Code Climate. |
|
@42wim This still merges cleanly and works correctly. You can reproduce the issue by replying to a message on Discord and checking how it appears on Telegram. This makes Discord replies work the same way as Telegram replies which is a nice improvement over the current status quo of it being broken. |
|
This is still needed. Looks like it needs a minor rebase. |
|
I managed to merge this in and did the minor rebase, and it works great. I'm going to start maintaining a fork of matterbridge to accept and merge pull requests regarding irc -> matrix -> discord since our organization needs this bridge to work. However, I can only test irc -> matrix -> discord so will need more people to help provide pull requests proven to fix the whatsapp and telegram issues. If anyone else is able to help test whatsapp and telegram please provide tested pull requests. https://github.com/bibanon/matterbridge/ Download linux intel 64-bit binary: https://github.com/bibanon/matterbridge/releases/tag/v1.26.2 |
No description provided.