Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sum_rate to sum_irate in dashboards and prometheusrules #744

Closed

Conversation

austincunningham
Copy link
Contributor

What

After deploying the monitoring stack I notices a number of panels with no data
This may be due to me using the latest version of grafana and prometheus in Operatorhub

  • grafana 7.5.15
  • prometheus 0.47.0

found a lot of the queries that failed were using
node_namespace_pod_container:container_cpu_usage_seconds_total:sum_rate

found they panels work again if switched to
node_namespace_pod_container:container_cpu_usage_seconds_total:sum_irate

And found an issue regarding this change regarding a breaking change from rate to irate
kubernetes-monitoring/kubernetes-mixin#670

Guessing this can't merge because of the older versions of prometheus and grafana don't support it.

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

@austincunningham: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 4, 2022

Hi @austincunningham. Thanks for your PR.

I'm waiting for a 3scale member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codeclimate
Copy link

codeclimate bot commented May 4, 2022

Code Climate has analyzed commit 586f560 and detected 0 issues on this pull request.

View more on Code Climate.

@austincunningham
Copy link
Contributor Author

Looks like this has already updated. must be working off an older branch.

@eguzki
Copy link
Member

eguzki commented May 4, 2022

Fixed in #744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants