Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backups/reduce-compression-ratio #278

Merged
merged 2 commits into from
Oct 25, 2023
Merged

backups/reduce-compression-ratio #278

merged 2 commits into from
Oct 25, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 25, 2023

Reduces the gzip compression ratio in the redis backups to improve speed.

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added do-not-merge/work-in-progress kind/bug Categorizes issue or PR as related to a bug. labels Oct 25, 2023
@3scale-robot 3scale-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. label Oct 25, 2023
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/L Requires few days to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 25, 2023
View reviewed changes
pkg/ssh/remote_exec.go Fixed Show fixed Hide fixed
@roivaz roivaz force-pushed the backups/reduce-compression-ratio branch from a87aba8 to 6b34c16 Compare October 25, 2023 15:06
@3scale-robot 3scale-robot added size/XS Requires less than an hour to complete the PR or the issue. and removed size/L Requires few days to complete the PR or the issue. labels Oct 25, 2023
@3scale-robot 3scale-robot added size/S Requires less than a day to complete the PR or the issue. and removed size/XS Requires less than an hour to complete the PR or the issue. labels Oct 25, 2023
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 013d70ea1913cbc9b25205b9c072e6ed8fd59815

@roivaz
Copy link
Member Author

roivaz commented Oct 25, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@roivaz roivaz changed the title wip backups/reduce-compression-ratio backups/reduce-compression-ratio Oct 25, 2023
@3scale-robot 3scale-robot merged commit 0ca8c49 into main Oct 25, 2023
5 checks passed
@3scale-robot 3scale-robot deleted the backups/reduce-compression-ratio branch October 25, 2023 15:46
@roivaz
Copy link
Member Author

roivaz commented Nov 3, 2023

Related to https://github.com/3scale/platform/issues/868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @3scale-robot @slopezz