Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package redis refactor #267

Merged
merged 17 commits into from
Sep 5, 2023
Merged

Package redis refactor #267

merged 17 commits into from
Sep 5, 2023

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Jul 26, 2023 •
edited
Loading

  • Add reusable server pools to reduce opening/closing of connection to the minimum
  • Full refactor to integrate branches of code that were slightly different but mostly did the same thing
  • Added a status to the TwemproxyConfig resource to surface the server selection that is written to the twemproxy configmap
  • Upgraded to go 1.20, mainly to be able to use the newly added support for multiple error wrapping
  • Added new clusterTopology field to Sentinel that allows specifying server aliases for each declared redis server. Aliases are now shown in the sentinel status, which simplifies seeing the status of the cluster at a glance.

@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XXL Requires more than a week to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jul 26, 2023
@roivaz
Copy link
Member Author

roivaz commented Jul 26, 2023

/kind feature
/priority important-soon

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. and removed needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-priority Indicates a PR or issue lacks a `priority/foo` label and requires one. labels Jul 26, 2023
@roivaz roivaz force-pushed the feat/reusable-server-pools branch 3 times, most recently from 78aabfe to ef7e768 Compare August 7, 2023 11:01
@roivaz roivaz force-pushed the feat/reusable-server-pools branch 3 times, most recently from 0a1751a to b12cdf0 Compare August 8, 2023 09:45
@roivaz
Copy link
Member Author

roivaz commented Aug 30, 2023

/retitle Package redis refactor

@3scale-robot 3scale-robot changed the title WIP Package redis refactor Package redis refactor Aug 30, 2023
@slopezz
Copy link
Member

slopezz commented Sep 1, 2023

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2023
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b5a1e10335883b6e37cde5f97968098e6d00c032

raelga
raelga approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@raelga raelga mentioned this pull request Sep 5, 2023
Merged
@roivaz
Copy link
Member Author

roivaz commented Sep 5, 2023

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@3scale-robot 3scale-robot merged commit 5dff3fa into main Sep 5, 2023
2 checks passed
@3scale-robot 3scale-robot deleted the feat/reusable-server-pools branch September 5, 2023 15:39
@roivaz
Copy link
Member Author

roivaz commented Nov 3, 2023

Related to https://github.com/3scale/platform/issues/868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raelga raelga raelga approved these changes

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XXL Requires more than a week to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roivaz @slopezz @3scale-robot @raelga