Feat/update component base UI #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enable file nesting for better project organization - Nest related files (css.ts, spec.tsx, stories.tsx) under main component files - Add common config file nesting patterns - Update .gitignore to include settings.json for team consistency
The Tooltip component was not responding to hover or click events because the BaseUITooltip.Trigger wrapper was missing. This component is required by Base UI to properly handle user interactions with the tooltip trigger element. Changes: - Wrap children with BaseUITooltip.Trigger - Tooltip now properly shows on hover - Tooltip now properly shows on focus (keyboard navigation)
- Rename component from 'Tabs' to 'Tab' - Rename interface 'Tab' to 'TabItem' to avoid confusion - Update all related types (TabsProps -> TabProps, TabsIntent -> TabIntent, etc) - Update Storybook title from 'Components/Tabs' to 'Components/Tab' - Update all file names and imports This change makes the component name more consistent with other UI libraries and better reflects that it represents a tabbed interface as a whole, not individual tabs. Suggested category placement: - Tab → SELECTION (navigation between content panels) - Tooltip → DISPLAY & FEEDBACK (information display)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.